Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix CI tests #33617

Merged
merged 2 commits into from
Oct 16, 2024
Merged

chore: fix CI tests #33617

merged 2 commits into from
Oct 16, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 79ce4bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 16, 2024 22:18
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 16, 2024 22:18
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33617/
on branch gh-pages at 2024-10-16 23:10 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (64bc5e6) to head (79ce4bd).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33617   +/-   ##
=======================================================
  Coverage                   58.35%   58.35%           
=======================================================
  Files                        2746     2746           
  Lines                       66370    66370           
  Branches                    15015    15015           
=======================================================
  Hits                        38727    38727           
  Misses                      24809    24809           
  Partials                     2834     2834
Flag Coverage Δ
unit 74.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc merged commit 47bafeb into feat/single-contact-id Oct 16, 2024
36 of 41 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/sci/ci branch October 16, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierre-lehnen-rc @tapiarafael